fix(local-file-list-adapter): navigation#16318
Merged
alperozturk96 merged 1 commit intoJan 21, 2026
Merged
Conversation
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
commented
Jan 19, 2026
| public void swapDirectory(final File directory) { | ||
| localFileListFragmentInterface.setLoading(true); | ||
| currentOffset = 0; | ||
| mFiles.clear(); |
Collaborator
Author
There was a problem hiding this comment.
updateUIForFirstPage will clear it.
alperozturk96
commented
Jan 19, 2026
| new Handler(Looper.getMainLooper()).post(() -> { | ||
| int from = mFiles.size(); | ||
| int to = updatedList.size(); | ||
| int headerOffset = shouldShowHeader() ? 1 : 0; |
Collaborator
Author
There was a problem hiding this comment.
Add shouldShowHeader into the calculation.
alperozturk96
commented
Jan 19, 2026
| new Handler(Looper.getMainLooper()).post(() -> { | ||
| mFiles = new ArrayList<>(firstPage); | ||
| mFilesAll = new ArrayList<>(firstPage); | ||
| mFiles.clear(); |
Collaborator
Author
There was a problem hiding this comment.
Clear mFiles in updateUIForFirstPage.
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16318.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
ZetaTom
approved these changes
Jan 21, 2026
ZetaTom
left a comment
ZetaTom
left a comment
Collaborator
There was a problem hiding this comment.
Works perfectly after rebasing onto master.
alperozturk96
deleted the
fix/local-file-list-adapter-navigation-crash
branch
Collaborator
Author
|
/backport to stable-3.35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
The app crashes when the user presses back from the local directory
How to reproduce?